Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 5.2.5 to 6.0.4 #232

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 5.2.5 to 6.0.4 #232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9c4e224
Bump com.github.spotbugs.snom:spotbugs-gradle-plugin from 5.2.5 to 6.0.4
dependabot[bot] Jan 1, 2024
7e78391
Merge branch 'main' into dependabot/gradle/com.github.spotbugs.snom-s…
big-andy-coates Jan 17, 2024
234d96e
Merge branch 'main' into dependabot/gradle/com.github.spotbugs.snom-s…
big-andy-coates Jan 17, 2024
9450861
Fix new spotbug issues
big-andy-coates Jan 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion buildSrc/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinCompile>().configureEach
}

dependencies {
implementation("com.github.spotbugs.snom:spotbugs-gradle-plugin:5.2.5") // https://plugins.gradle.org/plugin/com.github.spotbugs
implementation("com.github.spotbugs.snom:spotbugs-gradle-plugin:6.0.4") // https://plugins.gradle.org/plugin/com.github.spotbugs
implementation("com.diffplug.spotless:spotless-plugin-gradle:6.23.3") // https://plugins.gradle.org/plugin/com.diffplug.spotless
implementation("gradle.plugin.org.kt3k.gradle.plugin:coveralls-gradle-plugin:2.12.2") // https://plugins.gradle.org/plugin/com.github.kt3k.coveralls
implementation("org.javamodularity:moduleplugin:1.8.12") // https://plugins.gradle.org/plugin/org.javamodularity.moduleplugin
Expand Down
14 changes: 11 additions & 3 deletions src/main/java/org/creekservice/api/system/test/gradle/plugin/SystemTestExtension.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,15 +75,18 @@ public void verificationTimeout(final Duration timeout) {

/**
* @return list of additional arguments to pass to the test executor
* <p>See https://github.com/creek-service/creek-system-test/tree/main/executor for more
* info.
* <p>See <a
* href="https://github.com/creek-service/creek-system-test/tree/main/executor">Executor
* docs</a> for more info.
*/
public abstract ListProperty<String> getExtraArguments();

/**
* Set additional args to pass to the test executor.
*
* <p>See https://github.com/creek-service/creek-system-test/tree/main/executor for more info.
* <p>See <a
* href="https://github.com/creek-service/creek-system-test/tree/main/executor">Executor
* docs</a> for more info.
*
* @param args the extra args to use when running system tests.
*/
Expand All @@ -108,4 +111,9 @@ public DebugExtension getDebugging() {
public void debugging(final Action<DebugExtension> action) {
action.execute(debugExt);
}

// Avoid finalizer attacks: spotbugs CT_CONSTRUCTOR_THROW
@SuppressWarnings("deprecation")
@Override
protected final void finalize() {}
}
Loading