Skip to content

Commit

Permalink
Fix logging (#74)
Browse files Browse the repository at this point in the history
`mbknor-jackson-jsonschema` dependency is still on pre-`2.0.0` SLF4J api. Using `2.0.0` causes things to fail with a `ClassDefNotFound` exception :(

Raised mbknor/mbknor-jackson-jsonSchema#172
  • Loading branch information
big-andy-coates authored Nov 6, 2022
1 parent 338e342 commit 78ead0c
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
3 changes: 2 additions & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,8 @@ subprojects {
testImplementation("org.hamcrest:hamcrest-core:$hamcrestVersion")
testImplementation("com.google.guava:guava-testlib:$guavaVersion")
testImplementation("org.apache.logging.log4j:log4j-core:$log4jVersion")
testImplementation("org.apache.logging.log4j:log4j-slf4j2-impl:$log4jVersion")
// An old v1.x SLF4J impl as required by mbknor-jackson-jsonschema
testRuntimeOnly("org.apache.logging.log4j:log4j-slf4j-impl:$log4jVersion")
testRuntimeOnly("org.junit.jupiter:junit-jupiter-engine:$junitVersion")
}

Expand Down
3 changes: 2 additions & 1 deletion generator/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,8 @@ dependencies {
implementation("com.kjetland:mbknor-jackson-jsonschema_2.13:$jsonSchemaVersion")
implementation("io.github.classgraph:classgraph:$classGraphVersion")
implementation("org.apache.logging.log4j:log4j-core:$log4jVersion")
runtimeOnly("org.apache.logging.log4j:log4j-slf4j-impl:$log4jVersion")
// An old v1.x SLF4J impl as required by mbknor-jackson-jsonschema
implementation("org.apache.logging.log4j:log4j-slf4j-impl:$log4jVersion")

testImplementation(project(":test-types"))
}
Expand Down

0 comments on commit 78ead0c

Please sign in to comment.