fix imported identifiers in maps #174
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kevin-greene-ck could you take a look at this when you have a chance? |
|
cc @kevin-greene-ck (tagging you since you seem to be the most active contributor). Do you think this is something suitable for merging? I am also hitting this issue as a blocker for adopting this package for thrift file compilation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #173
Currently when resolving const values, identifiers are not resolved recursively, so if identifiers nested inside other ast nodes (eg maps) are used, the may not have been transformed correctly, which breaks referencing types in other files in these cases.