Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bugs contact modal #141

Merged
merged 1 commit into from
Nov 19, 2023
Merged

fix bugs contact modal #141

merged 1 commit into from
Nov 19, 2023

Conversation

poonam-ghewande
Copy link
Contributor

Summary

  1. fix bugs #224,#228,#230

Issue ticket number and link

https://github.com/credebl/automation-test-suite/issues/224
https://github.com/credebl/automation-test-suite/issues/228
https://github.com/credebl/automation-test-suite/issues/230

Checklist before requesting a review

  • All commits contain a DCO Signed-off-by line (we use the DCO GitHub app to enforce this).
  • Self-review of code & No unnecessary commented-out code.
  • All existing functionality remain intact.
  • Updated the README if necessary..
  • No hard-coded sensitive information.

@poonam-ghewande
fix bugs contact modal
db538b1 
Signed-off-by: Poonam Ghewande <[email protected]>
@poonam-ghewande poonam-ghewande self-assigned this Nov 15, 2023
@poonam-ghewande poonam-ghewande changed the base branch from main to dev November 15, 2023 15:12
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@sairanjit sairanjit self-requested a review November 19, 2023 13:41
@sairanjit sairanjit merged commit 9e99853 into dev Nov 19, 2023
6 checks passed
@sairanjit sairanjit deleted the bug/contact-modal-close-fix branch November 19, 2023 13:42
sairanjit pushed a commit that referenced this pull request Nov 27, 2023
@poonam-ghewande @sairanjit
fix: close contact modal after deletion (#141)
b1029fc 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
amitpadmani-awts pushed a commit that referenced this pull request Nov 27, 2023
@sairanjit @poonam-ghewande
Merge develop to main (#150)
e9945c2 
* fix: close contact modal after deletion (#141)

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* fix: import wallet failure scenario (#142)

* fix: import wallet failure scenario

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* fix: connection already exists

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* chore: bump ios version

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

---------

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* fix: scanning qrcode multiple times (#143)

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* feat/social-share certificate (#144)

Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* feat: deeplink with universal link (#145)

* feat: add agent link as deep link

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* chore: bump iOS version

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

---------

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* fix deep link issue (#147)

* feat: add agent link as deep link

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* chore: bump iOS version

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* chore: bump versions

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

---------

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* feat: add remote verification templates (#148)

* feat: add remote verification templates

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* chore: bump versions

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* fix: verifier capability for previous version

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

---------

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

---------

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Co-authored-by: poonam-ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Nov 27, 2023
@poonam-ghewande
fix: close contact modal after deletion (#141)
ceb09d0 
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Nov 29, 2023
@poonam-ghewande
fix: close contact modal after deletion (#141)
c7cc7a4 
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Nov 29, 2023
@poonam-ghewande
fix: close contact modal after deletion (#141)
727e43b 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
poonam-ghewande added a commit that referenced this pull request Dec 1, 2023
@poonam-ghewande
fix: close contact modal after deletion (#141)
0267293 
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Dec 1, 2023
@poonam-ghewande
fix: close contact modal after deletion (#141)
38fcad6 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
poonam-ghewande added a commit that referenced this pull request Dec 1, 2023
@poonam-ghewande
fix: close contact modal after deletion (#141)
5d9bef5 
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Dec 1, 2023
@poonam-ghewande
fix: close contact modal after deletion (#141)
b1ac02d 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
sairanjit added a commit that referenced this pull request Dec 1, 2023
@poonam-ghewande @sairanjit
Fix/remove contact (#160)
962abe0 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
fix: close contact modal after deletion (#141)
fix: import wallet failure scenario (#142)
fix: scanning qrcode multiple times (#143)
fix deep link issue (#147)
fix: credential detail modal button container (#155)
poonam-ghewande added a commit that referenced this pull request Dec 5, 2023
@poonam-ghewande
fix: close contact modal after deletion (#141)
43a3390 
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Dec 5, 2023
@poonam-ghewande
fix: close contact modal after deletion (#141)
db45035 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
poonam-ghewande added a commit that referenced this pull request Dec 5, 2023
@poonam-ghewande
Fix/remove contact (#160)
c7a5dc7 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
fix: close contact modal after deletion (#141)
fix: import wallet failure scenario (#142)
fix: scanning qrcode multiple times (#143)
fix deep link issue (#147)
fix: credential detail modal button container (#155)

Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Dec 5, 2023
@poonam-ghewande
fix: close contact modal after deletion (#141)
491c6f6 
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Dec 5, 2023
@poonam-ghewande
fix: close contact modal after deletion (#141)
b34bd8c 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Dec 5, 2023
@poonam-ghewande
Fix/remove contact (#160)
913155f 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
fix: close contact modal after deletion (#141)
fix: import wallet failure scenario (#142)
fix: scanning qrcode multiple times (#143)
fix deep link issue (#147)
fix: credential detail modal button container (#155)

Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Dec 11, 2023
@poonam-ghewande
fix: close contact modal after deletion (#141)
ba9930b 
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Dec 11, 2023
@poonam-ghewande
fix: close contact modal after deletion (#141)
0f5b5d4 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
poonam-ghewande added a commit that referenced this pull request Dec 11, 2023
@poonam-ghewande
Fix/remove contact (#160)
d7fe011 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
fix: close contact modal after deletion (#141)
fix: import wallet failure scenario (#142)
fix: scanning qrcode multiple times (#143)
fix deep link issue (#147)
fix: credential detail modal button container (#155)

Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Dec 11, 2023
@poonam-ghewande
fix: close contact modal after deletion (#141)
139fd3c 
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Dec 11, 2023
@poonam-ghewande
fix: close contact modal after deletion (#141)
2f5fd71 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Dec 11, 2023
@poonam-ghewande
Fix/remove contact (#160)
28bfa94 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
fix: close contact modal after deletion (#141)
fix: import wallet failure scenario (#142)
fix: scanning qrcode multiple times (#143)
fix deep link issue (#147)
fix: credential detail modal button container (#155)

Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Dec 14, 2023
@poonam-ghewande
fix: close contact modal after deletion (#141)
22a9a70 
Signed-off-by: Poonam Ghewande <[email protected]>
sairanjit pushed a commit that referenced this pull request Apr 15, 2024
@poonam-ghewande @sairanjit
fix: close contact modal after deletion (#141)
d3ab2f9 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
sairanjit pushed a commit that referenced this pull request Apr 15, 2024
@poonam-ghewande @sairanjit
Fix/remove contact (#160)
fe3d5db 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
fix: close contact modal after deletion (#141)
fix: import wallet failure scenario (#142)
fix: scanning qrcode multiple times (#143)
fix deep link issue (#147)
fix: credential detail modal button container (#155)

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
sairanjit pushed a commit that referenced this pull request Apr 15, 2024
@poonam-ghewande @sairanjit
fix: close contact modal after deletion (#141)
130730a 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
sairanjit pushed a commit that referenced this pull request Apr 15, 2024
@poonam-ghewande @sairanjit
fix: close contact modal after deletion (#141)
b50f1aa 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
sairanjit pushed a commit that referenced this pull request Apr 15, 2024
@poonam-ghewande @sairanjit
Fix/remove contact (#160)
b0e7620 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
fix: close contact modal after deletion (#141)
fix: import wallet failure scenario (#142)
fix: scanning qrcode multiple times (#143)
fix deep link issue (#147)
fix: credential detail modal button container (#155)

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
poonam-ghewande added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande
fix: close contact modal after deletion (#141)
34e9d37 
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande
fix: close contact modal after deletion (#141)
41ea685 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
poonam-ghewande added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande
Fix/remove contact (#160)
3558ba2 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
fix: close contact modal after deletion (#141)
fix: import wallet failure scenario (#142)
fix: scanning qrcode multiple times (#143)
fix deep link issue (#147)
fix: credential detail modal button container (#155)

Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande
fix: close contact modal after deletion (#141)
59c486b 
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande
fix: close contact modal after deletion (#141)
ba5ebe0 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande
Fix/remove contact (#160)
53effa6 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
fix: close contact modal after deletion (#141)
fix: import wallet failure scenario (#142)
fix: scanning qrcode multiple times (#143)
fix deep link issue (#147)
fix: credential detail modal button container (#155)

Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande
fix: close contact modal after deletion (#141)
38ac44e 
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande
fix: close contact modal after deletion (#141)
6c803ef 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande
Fix/remove contact (#160)
f5f369c 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
fix: close contact modal after deletion (#141)
fix: import wallet failure scenario (#142)
fix: scanning qrcode multiple times (#143)
fix deep link issue (#147)
fix: credential detail modal button container (#155)

Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande
fix: close contact modal after deletion (#141)
d503586 
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande
fix: close contact modal after deletion (#141)
f2c0ba6 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande
Fix/remove contact (#160)
8ec93e9 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
fix: close contact modal after deletion (#141)
fix: import wallet failure scenario (#142)
fix: scanning qrcode multiple times (#143)
fix deep link issue (#147)
fix: credential detail modal button container (#155)

Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande
fix: close contact modal after deletion (#141)
122a198 
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande
fix: close contact modal after deletion (#141)
75d4766 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Poonam Ghewande <[email protected]>
poonam-ghewande added a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande
Fix/remove contact (#160)
2be4a2f 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
fix: close contact modal after deletion (#141)
fix: import wallet failure scenario (#142)
fix: scanning qrcode multiple times (#143)
fix deep link issue (#147)
fix: credential detail modal button container (#155)

Signed-off-by: Poonam Ghewande <[email protected]>
sairanjit pushed a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande @sairanjit
fix: close contact modal after deletion (#141)
dc6f30a 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
sairanjit pushed a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande @sairanjit
fix: close contact modal after deletion (#141)
5acc5cd 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
sairanjit pushed a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande @sairanjit
Fix/remove contact (#160)
f73144e 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
fix: close contact modal after deletion (#141)
fix: import wallet failure scenario (#142)
fix: scanning qrcode multiple times (#143)
fix deep link issue (#147)
fix: credential detail modal button container (#155)

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
sairanjit pushed a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande @sairanjit
fix: close contact modal after deletion (#141)
3a056b5 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
sairanjit pushed a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande @sairanjit
fix: close contact modal after deletion (#141)
2419f97 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
sairanjit pushed a commit that referenced this pull request Apr 16, 2024
@poonam-ghewande @sairanjit
Fix/remove contact (#160)
fb184f2 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
fix: close contact modal after deletion (#141)
fix: import wallet failure scenario (#142)
fix: scanning qrcode multiple times (#143)
fix deep link issue (#147)
fix: credential detail modal button container (#155)

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
sairanjit pushed a commit that referenced this pull request Sep 5, 2024
@poonam-ghewande @sairanjit
fix: close contact modal after deletion (#141)
7c67c8a 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
sairanjit pushed a commit that referenced this pull request Sep 5, 2024
@poonam-ghewande @sairanjit
fix: close contact modal after deletion (#141)
3395432 
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
sairanjit pushed a commit that referenced this pull request Sep 5, 2024
@poonam-ghewande @sairanjit
Fix/remove contact (#160)
53d3903 
Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
fix: close contact modal after deletion (#141)
fix: import wallet failure scenario (#142)
fix: scanning qrcode multiple times (#143)
fix deep link issue (#147)
fix: credential detail modal button container (#155)

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
sairanjit added a commit that referenced this pull request Sep 5, 2024
@sairanjit @poonam-ghewande
Merge develop to main (#150)
d25e341 
* fix: close contact modal after deletion (#141)

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* fix: import wallet failure scenario (#142)

* fix: import wallet failure scenario

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* fix: connection already exists

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* chore: bump ios version

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

---------

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* fix: scanning qrcode multiple times (#143)

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* feat/social-share certificate (#144)

Co-authored-by: Sai Ranjit Tummalapalli <[email protected]>
Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* feat: deeplink with universal link (#145)

* feat: add agent link as deep link

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* chore: bump iOS version

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

---------

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* fix deep link issue (#147)

* feat: add agent link as deep link

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* chore: bump iOS version

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* chore: bump versions

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

---------

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* feat: add remote verification templates (#148)

* feat: add remote verification templates

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* chore: bump versions

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

* fix: verifier capability for previous version

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

---------

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>

---------

Signed-off-by: Sai Ranjit Tummalapalli <[email protected]>
Co-authored-by: poonam-ghewande <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sairanjit sairanjit Awaiting requested review from sairanjit

Assignees

@poonam-ghewande poonam-ghewande

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poonam-ghewande @sairanjit