Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/button hover effect #244

Closed

Conversation

Dev-JoyA
Copy link

@Dev-JoyA Dev-JoyA commented Oct 4, 2024

Fixes

Description

I created classes for button-hover and button-active effects to improve user experience and interactivity. Previously, the buttons lacked visual feedback when hovered over, which diminished the overall interactivity and user experience (UX).

Technical details

I created a class and applied it to all the buttons to ensure consistent hover and active effects across the page.
One specific button in the header had a unique design in vocabulary.css that I didn’t want to override.
To preserve this design, I used an ID selector for that button, allowing it to keep its original styling while still incorporating the hover and active effects for a more interactive experience.

##Suggestion/Recommendation
I suggest that the class be moved to vocabulary.css(upstream), so all website can use it , to enhance user experience

Tests

I ran the code in my browser using Live Server in VSCode to test the UI changes. This allowed me to visually confirm that the updates to the structure and styling were correctly applied.

Screenshots

The UI after adding the button class, the Explore CC button remains the same , but it has an Hover effect and active effect
Screenshot 2024-10-04 at 11 11 01

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Dev-JoyA Dev-JoyA requested a review from a team as a code owner October 4, 2024 10:12
@Dev-JoyA Dev-JoyA requested review from TimidRobot and possumbilities and removed request for a team October 4, 2024 10:12
Copy link

netlify bot commented Oct 4, 2024

Deploy Preview for cc-search-portal ready!

Name Link
🔨 Latest commit 092127a
🔍 Latest deploy log https://app.netlify.com/sites/cc-search-portal/deploys/66ffbf846f73b0000893f5ea
😎 Deploy Preview https://deploy-preview-244--cc-search-portal.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@possumbilities
Copy link
Contributor

@Dev-JoyA Hi, and thank you for doing this work. After further review the Issue in question here as moved to 🚧 status: blocked Blocked & therefore, not ready for work so I'm closing this PR for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[Feature] Buttons Lack Hover Reactions - Poor User Experience
2 participants