Add docker to the local development #29 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Silvia-Wachira
requested review from
TimidRobot and
Shafiya-Heena
and removed request for
a team
|
@TimidRobot I worked on this issue. Could you give me a review |
6 tasks
TimidRobot
requested changes
Oct 22, 2024
There was a problem hiding this comment.
Please re-reference the related files in https://github.com/creativecommons/cc-resource-archive
| @@ -0,0 +1,23 @@ | |||
| version: '3' | |||
| services: | |||
| jekyll: | |||
There was a problem hiding this comment.
The build section is missing
Comment on lines
+27
to
+28
| # Copy the rest of your site files | ||
| COPY . . |
There was a problem hiding this comment.
better to use mounts instead of copying files
There was a problem hiding this comment.
It would be better if this file was based on https://github.com/creativecommons/cc-resource-archive/blob/e00da263989a8f042151a459380469bf9b8cd8ee/dev/jekyll/Dockerfile
Comment on lines
+12
to
+23
| node: | ||
| image: node:latest # Use an appropriate Node.js image | ||
| volumes: | ||
| - ../:/usr/src/app # Mount your project directory | ||
| working_dir: /usr/src/app | ||
| # command: prettier --write docs/index.html # Adjust the file types as needed | ||
|
|
||
| # Add an initialization step to install Prettier before running | ||
| # entrypoint: /bin/sh -c "npm install --global prettier && prettier --write docs/index.html" | ||
|
|
||
| #multiple files | ||
| entrypoint: /bin/sh -c "npm install --global prettier && prettier --write 'docs/**/*.html'" |
| services: | ||
| jekyll: | ||
| image: my-jekyll-app:latest | ||
| # command: jekyll serve --watch --host 0.0.0.0 |
Comment on lines
+6
to
+7
| #volumes: | ||
| # - .:/srv/jekyll |
There was a problem hiding this comment.
better to use mounts instead of copying files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Description
This PR adds Docker support to simplify local development by creating a consistent environment across different machines and setups. Docker ensures that all dependencies are installed correctly, reducing issues related to version mismatches and environmental differences. This will make the development process smoother and more reliable for all contributors.
Technical details
Tests
Screenshots
screen-capture.webm
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin