Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

restore proper definition of width/height #58

Merged
merged 2 commits into from
Aug 19, 2023

Conversation

ErwanMAS
Copy link
Contributor

Width/Height for GPU parameter was switched.

@openshift-ci openshift-ci bot requested review from baude and cfergeau August 17, 2023 16:05
@openshift-ci
Copy link

openshift-ci bot commented Aug 17, 2023

Hi @ErwanMAS. Thanks for your PR.

I'm waiting for a crc-org member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Collaborator

@cfergeau cfergeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, though it would be easier to read with width and then height in most places.

cmd/vfkit/main.go Show resolved Hide resolved
doc/usage.md Show resolved Hide resolved
doc/usage.md Outdated Show resolved Hide resolved
pkg/config/virtio_test.go Outdated Show resolved Hide resolved
@ErwanMAS ErwanMAS requested a review from cfergeau August 18, 2023 13:54
@cfergeau
Copy link
Collaborator

/lgtm
/approve

@openshift-ci
Copy link

openshift-ci bot commented Aug 19, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cfergeau cfergeau merged commit 006fdb4 into crc-org:main Aug 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants