Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix e2e result junit format #4386

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix e2e result junit format #4386

wants to merge 1 commit into from

Conversation

albfan
Copy link

@albfan albfan commented Oct 3, 2024

Fixes: Issue #4373

Relates to: PR #4376

Solution/Idea

adapt junit report reportportal format

Proposed changes

post process xml junit to adapt xml to reportportal format

@openshift-ci openshift-ci bot requested review from evidolob and gbraad October 3, 2024 14:13
Copy link

openshift-ci bot commented Oct 3, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign adrianriobo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@albfan
Copy link
Author

albfan commented Oct 3, 2024

NOTE Windows still not tested

Copy link
Contributor

@adrianriobo adrianriobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to understand the context and the cause of this change on the commit log. (Also if possible prefix the commit log with [QE])

@@ -0,0 +1,19 @@
<xsl:stylesheet version="1.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are those xsls files exactly the same? If that is the case we need to have it only once and add it from the Containerfile

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I was rounding the idea. Will rework the PR

@albfan
Copy link
Author

albfan commented Oct 3, 2024

Doing test on reportportal, only content on failure tag is use to fill stacktrace and logs

Our reason on a failure test is on message attribute from failure node, so this transformation remove message attribute and set as failure node content

@albfan albfan force-pushed the fix_e2e_junit branch 4 times, most recently from 4bdcada to 3ea1f34 Compare October 7, 2024 10:41
Copy link

openshift-ci bot commented Oct 9, 2024

@albfan: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration-crc b96d82d link true /test integration-crc
ci/prow/e2e-crc b96d82d link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants