Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: microshift: Don't force network-mode to 'user' #3804

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: microshift: Don't force network-mode to 'user' #3804

wants to merge 2 commits into from

Commits on Aug 25, 2023

  1. test: microshift: Don't force network-mode to 'user' 

    We want our testing to be as close as possible to what end-users will
experience. Changing `network-mode` is a significant difference from the
default.
With crc-org/snc#797 fixed, we no longer need to
force it to `user`.
    @cfergeau
    cfergeau committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    3d71018 View commit details
    Browse the repository at this point in the history

  2. Revert "e2e test: Ignore network-mode config property for non linux p… 

    …latform"

This reverts commit 557ec94.

We no longer set network-mode as part of the tests, so this code is not
needed.
    @cfergeau
    cfergeau committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    9bae8e5 View commit details
    Browse the repository at this point in the history