Release 0.8.0 #29
Merged
Release 0.8.0 #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The application now has a metrics handler compatible with prometheus. Besides default metrics, database pooling metrics are also shared at the moment.
Creating a transaction and failing to end it with either a commit or rollback leaves db pool connections in an acquired state, unavailable to other requests. There were two instances where this was happening, this resulted in the service eventually becoming unresponsive after the offending code was called enough times and all the connections were exhausted.
crazybolillo
force-pushed
the
release-0.8.0
branch
from
f33d7ed to
54a4d0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This release fixes a nasty bug caused by leaked connections, it also adds metrics, which will give more visibility to the process status.