update message and formatting

crater-invoice-inc · Mar 3, 2022 · 9a0de9f · 9a0de9f
1 parent a23644c
commit 9a0de9f
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 8 deletions.
diff --git a/app/Http/Controllers/V1/Admin/Settings/CompanyCurrencyCheckTransactionsController.php b/app/Http/Controllers/V1/Admin/Settings/CompanyCurrencyCheckTransactionsController.php
@@ -20,14 +20,8 @@ public function __invoke(Request $request)
 
         $this->authorize('manage company', $company);
 
-        if ($company->hasTransactions()) {
-            return response()->json([
-                'success' => false,
-            ]);
-        }
-
         return response()->json([
-            'success' => true,
+            'has_transactions' => $company->hasTransactions(),
         ]);
     }
 }
diff --git a/app/Http/Controllers/V1/Admin/Settings/UpdateCompanySettingsController.php b/app/Http/Controllers/V1/Admin/Settings/UpdateCompanySettingsController.php
@@ -26,7 +26,7 @@ public function __invoke(UpdateSettingsRequest $request)
         if ($companyCurrency !== $data['currency'] && $company->hasTransactions()) {
             return response()->json([
                 'success' => false,
-                'message' => 'You cannot change currency once transaction is created.'
+                'message' => 'Cannot update company currency after transactions are created.'
             ]);
         }