Make Prometheus SSL optional #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hlcianfagna
reviewed
Oct 24, 2023
hlcianfagna
approved these changes
Oct 24, 2023
hammerhead
force-pushed
the
hammerhead/prometheus-ssl-optional
branch
7 times, most recently
from
2255bab to
664ad85
Compare
hammerhead
force-pushed
the
hammerhead/prometheus-ssl-optional
branch
from
664ad85 to
bcfc032
Compare
hammerhead
force-pushed
the
hammerhead/prometheus-ssl-optional
branch
from
bcfc032 to
1e1c20b
Compare
Version 8 was a leftover from before upgrading to Amazon Linux 2023
hammerhead
force-pushed
the
hammerhead/prometheus-ssl-optional
branch
4 times, most recently
from
b6df2a0 to
c7861ce
Compare
hammerhead
force-pushed
the
hammerhead/prometheus-ssl-optional
branch
from
c7861ce to
6186fc0
Compare
|
I added automated Terraform tests now, at least as far as input variable validation goes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
Based on feedback we got that running without SSL is preferred in some non-public VPC environments.
This moves most of the YAML generation from the template into the main Terraform code, as recommended by Terraform due to better syntax/type validation.
Checklist