DMS: Skip primary key columns in SET clauses for UPDATE statements
#18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CrateDB does not allow changing primary key columns, even when setting them to their current value.
hammerhead
commented
Aug 16, 2024
| if column_name in self.primary_keys: | ||
| continue | ||
|
|
||
| constraint = f"{self.DATA_COLUMN}['{column_name}'] = '{column_value}'" |
There was a problem hiding this comment.
It should be ok to wrap every column in quotes, since CrateDB already has type information for every column and will auto-cast
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 815 823 +8
=========================================
+ Hits 815 823 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
amotl
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CrateDB does not allow changing primary key columns, even when setting them to their current value.