Skip to content

Commit

Permalink
docs(publish): Describe why pkgid isn't used
Browse files Browse the repository at this point in the history
  • Loading branch information
epage committed Oct 7, 2024
1 parent 74a7b95 commit 06a4e44
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions src/steps/publish.rs
Original file line number Diff line number Diff line change
Expand Up @@ -183,6 +183,11 @@ pub fn publish(pkgs: &[plan::PackageRelease], dry_run: bool) -> Result<(), CliEr
};
// feature list to release
let features = &pkg.features;
// HACK: Ignoring the more precise `pkg.meta.id`. While it has been stabilized,
// the version won't match after we do a version bump and it seems too messy to bother
// trying to specify it.
// atm at least Cargo doesn't seem to mind if `crate_name` is also a transitive dep, unlike
// other cargo commands
let pkgid = Some(crate_name);
if !crate::ops::cargo::publish(
dry_run,
Expand Down

0 comments on commit 06a4e44

Please sign in to comment.