Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add support for Bosch with temperature float value #2068

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

zhixuan2333
Copy link

@zhixuan2333 zhixuan2333 commented Feb 19, 2024

@crankyoldgit crankyoldgit self-requested a review February 19, 2024 05:22
Copy link
Owner

@crankyoldgit crankyoldgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First off, thanks for taking the time and effort to improve the library.
Appologies for all the suggestions/questions.

Can you please also provide some state[] corresponding to the 0.5deg additions so we can add some unit tests to verify and check the code against known-good data?

src/ir_Bosch.cpp Outdated Show resolved Hide resolved
src/ir_Bosch.cpp Show resolved Hide resolved
src/ir_Bosch.cpp Show resolved Hide resolved
src/ir_Bosch.cpp Outdated Show resolved Hide resolved
src/ir_Bosch.h Outdated Show resolved Hide resolved
src/ir_Bosch.h Outdated Show resolved Hide resolved
@zhixuan2333
Copy link
Author

zhixuan2333 commented Feb 19, 2024

Can you please also provide some state[] corresponding to the 0.5deg additions so we can add some unit tests to verify and check the code against known-good data?

Mode Hex
Cool/16.0 0xC23DBF4000FFC23DBF4000FFD5660010004B
Cool/19.0 0xC23DBF4030CFC23DBF4030CFD5660000003B
Cool/19.5 0xC23DBF4030CFC23DBF4030CFD5662000005B
Cool/20.0 0xC23DBF4020DFC23DBF4020DFD5660000003B
Cool/20.5 0xC23DBF4020DFC23DBF4020DFD5662000005B
Cool/21.0 0xC23DBF40609FC23DBF40609FD5660000003B
Cool/21.5 0xC23DBF40609FC23DBF40609FD5662000005B
Cool/22.0 0xC23DBF40708FC23DBF40708FD5660000003B
Cool/30.0 0xC23DBF40B04FC23DBF40B04FD5660000003B

and also here.
https://docs.google.com/spreadsheets/d/1gf2wcYWTul5B5qxhGLA25nAKQwmfrvwjtUM3SG4Ty9M/edit?usp=sharing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants