Skip to content

Commit

Permalink
Fixed capability name after merging main
Browse files Browse the repository at this point in the history
  • Loading branch information
craigtaverner committed Dec 16, 2024
1 parent 05408b5 commit cef5753
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 9 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,8 @@ protected boolean supportsInferenceTestService() {

@Override
protected boolean supportsIndexModeLookup() throws IOException {
// CCS does not yet support JOIN_LOOKUP_V5 and clusters falsely report they have this capability
// return hasCapabilities(List.of(JOIN_LOOKUP_V5.capabilityName()));
// CCS does not yet support JOIN_LOOKUP_V6 and clusters falsely report they have this capability
// return hasCapabilities(List.of(JOIN_LOOKUP_V6.capabilityName()));
return false;
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4911,7 +4911,7 @@ public void testPlanSanityCheck() throws Exception {
}

public void testPlanSanityCheckWithBinaryPlans() throws Exception {
assumeTrue("Requires LOOKUP JOIN", EsqlCapabilities.Cap.JOIN_LOOKUP_V5.isEnabled());
assumeTrue("Requires LOOKUP JOIN", EsqlCapabilities.Cap.JOIN_LOOKUP_V6.isEnabled());

var plan = optimizedPlan("""
FROM test
Expand Down Expand Up @@ -5916,7 +5916,7 @@ public void testLookupStats() {
* \_EsRelation[language_code][LOOKUP][language_code{f}#18, language_name{f}#19]
*/
public void testLookupJoinPushDownFilterOnJoinKeyWithRename() {
assumeTrue("Requires LOOKUP JOIN", EsqlCapabilities.Cap.JOIN_LOOKUP_V5.isEnabled());
assumeTrue("Requires LOOKUP JOIN", EsqlCapabilities.Cap.JOIN_LOOKUP_V6.isEnabled());

String query = """
FROM test
Expand Down Expand Up @@ -5959,7 +5959,7 @@ public void testLookupJoinPushDownFilterOnJoinKeyWithRename() {
* \_EsRelation[language_code][LOOKUP][language_code{f}#18, language_name{f}#19]
*/
public void testLookupJoinPushDownFilterOnLeftSideField() {
assumeTrue("Requires LOOKUP JOIN", EsqlCapabilities.Cap.JOIN_LOOKUP_V5.isEnabled());
assumeTrue("Requires LOOKUP JOIN", EsqlCapabilities.Cap.JOIN_LOOKUP_V6.isEnabled());

String query = """
FROM test
Expand Down Expand Up @@ -6003,7 +6003,7 @@ public void testLookupJoinPushDownFilterOnLeftSideField() {
* \_EsRelation[language_code][LOOKUP][language_code{f}#18, language_name{f}#19]
*/
public void testLookupJoinPushDownDisabledForLookupField() {
assumeTrue("Requires LOOKUP JOIN", EsqlCapabilities.Cap.JOIN_LOOKUP_V5.isEnabled());
assumeTrue("Requires LOOKUP JOIN", EsqlCapabilities.Cap.JOIN_LOOKUP_V6.isEnabled());

String query = """
FROM test
Expand Down Expand Up @@ -6048,7 +6048,7 @@ public void testLookupJoinPushDownDisabledForLookupField() {
* \_EsRelation[language_code][LOOKUP][language_code{f}#19, language_name{f}#20]
*/
public void testLookupJoinPushDownSeparatedForConjunctionBetweenLeftAndRightField() {
assumeTrue("Requires LOOKUP JOIN", EsqlCapabilities.Cap.JOIN_LOOKUP_V5.isEnabled());
assumeTrue("Requires LOOKUP JOIN", EsqlCapabilities.Cap.JOIN_LOOKUP_V6.isEnabled());

String query = """
FROM test
Expand Down Expand Up @@ -6101,7 +6101,7 @@ public void testLookupJoinPushDownSeparatedForConjunctionBetweenLeftAndRightFiel
* \_EsRelation[language_code][LOOKUP][language_code{f}#19, language_name{f}#20]
*/
public void testLookupJoinPushDownDisabledForDisjunctionBetweenLeftAndRightField() {
assumeTrue("Requires LOOKUP JOIN", EsqlCapabilities.Cap.JOIN_LOOKUP_V5.isEnabled());
assumeTrue("Requires LOOKUP JOIN", EsqlCapabilities.Cap.JOIN_LOOKUP_V6.isEnabled());

String query = """
FROM test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2331,7 +2331,7 @@ public void testVerifierOnMissingReferences() {
}

public void testVerifierOnMissingReferencesWithBinaryPlans() throws Exception {
assumeTrue("Requires LOOKUP JOIN", EsqlCapabilities.Cap.JOIN_LOOKUP_V5.isEnabled());
assumeTrue("Requires LOOKUP JOIN", EsqlCapabilities.Cap.JOIN_LOOKUP_V6.isEnabled());

// Do not assert serialization:
// This will have a LookupJoinExec, which is not serializable because it doesn't leave the coordinator.
Expand Down

0 comments on commit cef5753

Please sign in to comment.