-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure multiple shutdown attempts yield #25
Ensure multiple shutdown attempts yield #25
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for catching this. Code looks correct, just want to manually run some checks and verify before merging after I'm done with work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the work, please address these comments and then we can merge.
Thanks for making the test changes, looks good |
Thank you for your help! |
* Ensure multiple shutdown attempts behave correctly --------- Authored-by: Caleb Leinz <[email protected]>
Doc changes and logging changes Option to toggle write failure behavior Ensure multiple shutdown attempts behave correctly (#25) * Ensure multiple shutdown attempts behave correctly --------- Authored-by: Caleb Leinz <[email protected]>
Currently if the state is set to disconnect, and the user hits
poll_shutdown
, the function will never yield.My proposed solution (similar to how tokio operates) is to just error in the event a closed stream is told to shutdown again.