Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7095] Rename dialog offers the ability to edit a broken reference but will not allow the user to open the content form #4079

Draft
wants to merge 9 commits into
base: develop
Choose a base branch
from
Draft

[7095] Rename dialog offers the ability to edit a broken reference but will not allow the user to open the content form #4079

wants to merge 9 commits into from

Conversation

jvega190
Copy link
Member

@jvega190
[7095] Rename dialog offers the ability to edit a broken reference bu…
efb28dc 
…t will not allow the user to open the content form
@jvega190 jvega190 requested a review from rart as a code owner July 31, 2024 21:28
@jvega190
Copy link
Member Author

@rart the issue is that when on a form, if you open the renameDialog and the item has dependencies, they will show up in the dialog, and if possible, the Edit icon shows up. The problem is that due to our current limitation of only one open form, we can't open the dependency's form too.
I created this PR with a prop allowEditDependencies (defaults to true), and set it to false when opening from a form for you to analize this alternative

@rart rart marked this pull request as draft August 1, 2024 18:53
rart
rart requested changes Aug 29, 2024
View reviewed changes
Copy link
Member

@rart rart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jvega190 let's add a separate form dialog where it is needed for this action and use that instead of dispatching the regular edit action

@jvega190
Copy link
Member Author

jvega190 commented Sep 3, 2024

This is ready for review, for 4.3

rart
rart reviewed Sep 9, 2024
View reviewed changes
Copy link
Member

@rart rart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments

@jvega190 jvega190 requested a review from rart September 9, 2024 22:01
@jvega190 jvega190 marked this pull request as ready for review November 14, 2024 23:08
@rart rart marked this pull request as draft November 19, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rart rart Awaiting requested review from rart rart is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvega190 @rart