Server with db #15
Open
Server with db #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Пока еще не дописал и не затестил
uml для базы данных
Вернул параметризированный опциональный конструктор
но насчет асинхронности тут вопрос стоит, потому что напрягает функция accept
fix require
…dmade Async udp server handmade
a-badin
commented
Jun 8, 2023
| #include <optional> | ||
| #include "url_dispatcher.hpp" | ||
|
|
||
| using udp = boost::asio::ip::udp; |
There was a problem hiding this comment.
лучше выделить в отдельный namespace или вообще не использовать using в hpp файлах
| _socket, | ||
| _streambuf, | ||
| [self = shared_from_this()]( | ||
| boost::system::error_code error, |
There was a problem hiding this comment.
такие большие функции лучше выносить в методы класса
| void async_accept() { | ||
| _socket.emplace(_io_context); | ||
|
|
||
| _acceptor.async_accept(*_socket, [&](boost::system::error_code error) { |
There was a problem hiding this comment.
лучше явно перечислять захват
| class UrlDispatcher { | ||
| public: | ||
| UrlDispatcher() : urls() { | ||
| std::shared_ptr<UserView> user_v(new UserView()); |
| public: | ||
| DatabaseTable(const std::string&); | ||
|
|
||
| ~DatabaseTable(); |
|
|
||
| DatabaseTable::DatabaseTable(const std::string &tableName) : tableName(tableName) | ||
| { | ||
| db = new pqxx::connection( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.