Killer feature update #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Добавлены структуры в соответствии с UML-диаграммой
Добавлены исполняемые файлы в соответствии с UML-диаграммой
…k-education/2023_1_Rabotyagi into killer-feature-update
спать
…k-education/2023_1_Rabotyagi into killer-feature-update
a-badin
commented
Jun 8, 2023
|
|
||
| int result = init_app_settings(); | ||
|
|
||
| int flag = 3; |
There was a problem hiding this comment.
принимали бы тогда в enum тоже а не в int
| break; | ||
| } | ||
| switch (flag) { | ||
| case (int)LoginWindow::States::to_log_window: |
|
|
||
| class UserManager { | ||
| private: | ||
| static std::shared_ptr<User> instance; |
There was a problem hiding this comment.
есть реализация синглтона, которая называется сигнлотоном Майерса, static std::shared_ptr<User> instance; нужно положить в тело функции, тогда компилятор гарантирует, что если 2 потока одновременно вызовут getInstance не будет гонки на инициализации
| static std::shared_ptr<QSettings> settings; | ||
| UserManager() {} | ||
| UserManager(const UserManager&); | ||
| UserManager& operator=( UserManager& ); |
| #define REGISTRATIONWINDOW_H | ||
|
|
||
| #include <QDialog> | ||
| #include "../../controls/user_control/user_control.h" |
There was a problem hiding this comment.
надо правильно настраивать include dir
|
|
||
| try | ||
| { | ||
| cpr::Response response = cpr::Get( |
There was a problem hiding this comment.
блокирующийся вызов - не очень хорошо
| struct Channel : Base | ||
| { | ||
| unsigned int guild_id=0; | ||
| std::string name=""; |
There was a problem hiding this comment.
классы не нужно инициализировать явно
| std::string password=""; | ||
| std::string email=""; | ||
| std::string last_login=""; | ||
| unsigned int guild_id=-1; |
There was a problem hiding this comment.
для unsigned лучше явно взять std::numeric_limits::max()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.