Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Cyclic Array #4985

Merged
merged 8 commits into from
Dec 23, 2024
Merged

update Cyclic Array #4985

merged 8 commits into from
Dec 23, 2024

Conversation

Sosuke23
Copy link
Contributor

@Sosuke23 Sosuke23 commented Dec 16, 2024 •
edited
Loading

Place an "x" in the corresponding checkbox if it is done or does not apply to this pull request.

  • I have tested my code.
  • I have added my solution according to the steps here.
  • I have followed the code conventions mentioned here.
    • I understand that if it is clear that I have not attempted to follow these conventions, my PR will be closed.
    • If changes are requested, I will re-request a review after addressing them.
  • I have linked this PR to any issues that it closes.

AC (Python):
Screenshot from 2024-12-17 13-09-06
Screenshot from 2024-12-17 13-09-12

AC (C++):
Screenshot from 2024-12-17 13-09-22
Screenshot from 2024-12-17 13-09-29

@Sosuke23 Sosuke23 requested a review from dongliuu as a code owner December 16, 2024 14:17
dongliuu
dongliuu requested changes Dec 16, 2024
View reviewed changes
solutions/platinum/cses-1191.mdx Outdated Show resolved Hide resolved
@Sosuke23 Sosuke23 changed the title py sol for Cyclic Array update Cyclic Array Dec 17, 2024
@Sosuke23 Sosuke23 requested a review from dongliuu December 17, 2024 07:37
dongliuu
dongliuu approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@dongliuu dongliuu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@ryanchou-dev ryanchou-dev merged commit d322bfc into cpinitiative:master Dec 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanchou-dev ryanchou-dev ryanchou-dev approved these changes

@dongliuu dongliuu dongliuu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Sosuke23 @dongliuu @ryanchou-dev