feat: Add logs to ease debugging #844
Conversation
The ReloadInterceptorWebView component is responsible to intercept the WebView's reload events and to remount the component instead of just doing an HTML reload With current implementation, if the cozy-home app is in an error state due to invalid cookies, then reloading ReloadInterceptorWebView won't fix the problem as the same HTML content will be served from the CozyProxyWebView that is not re-rendered To fix this, we want to do the reload process on the CozyProxyWebView instead, so the getIndexHtmlForSlug is called and then cookies would be refreshed
|
How are we going to access these logs? |
|
They would be visible in the extracted file if we re-use this PR someday: #325 Until then, today the only way to access them is from the dev console, and maybe from Sentry if they are followed by an error (however I'm not sure about the exact rule here). Example of a Sentry log that contains an exception and show some previous |
|
Yep but in our case, we don't have any raised error, so the debug log will not be sent. So with this, ATM, it's not useful, no? What about creating a flag to activate on the cozy that sent these debug logs for this feature? |
|
I'm not sure that sending all debug logs to Sentry would be a good idea (this would mean a lot of new Sentry issues that would be difficult to classify) However maybe we can log those on a file (only if the flag exists as it may reduce performances) and then add an option to download/share the file from cozy settings? If we do this we should improve the file logging a bit to make sure that the file won't grow too big |
|
So as for today, this PR is not useful. Right? If yes, should we close it? |
|
ping @Ldoppea |
|
ping @Ldoppea |
This PR adds some logs to ease debugging. Those are basically logs on functions entry but also logs on mount/unmount for CozyAppScreen and HomeView