refactoring

[maboiteaspam]

hi,

here is the refactoring applied. While general compatibility was kept in order to insure that no breaking changes was introduced, here is a list of interesting changes,

• lib/cozy-light now is a kind of cozy kernel, holding reference to necessary sub module, manage proper init / exit process of a cozy instance
• all sub modules are now in a independant files, tests also reflect that
• a new cozy.status is introduced to know if the app is actively running the front gui
• cozyLight.actions exposes a new event 'restarted' to listen this event
• install / uninstall app and plugins are updated to not let twice app being installed together
• uninstall command now requires the name app instead of install source reference
• mocha integration is updated, the options are deported to a specific files when possible
• should.js is used whenever it is possible in the test scenarios to improve tests results understanding
• tests are now delegated to specific sh files for process isolations
• package file was cleaned of several useless dependency, at least not explicitly required.
• application helpers and plugin helpers exposes cozyLight instance as last arguments
• README was updated with fedora specifics install steps
• also added tip to faster test run

HTH

[maboiteaspam]

Can t find my comment about printit anymore.
Two remarks about this logger,
does not support log level filters
there is some hardcoded stuff inside related to NODE_ENV variable that i could not control form the lib.
This was a bit desperating.

[maboiteaspam]

i found the right rules for parens,
http://eslint.org/docs/rules/space-in-parens.html

test/npm-helpers.js
  11:32  error  There should be no spaces inside this paren  space-in-parens
  12:31  error  There should be no spaces inside this paren  space-in-parens

✖ 82 problems

:x

[frankrousseau]

Ok, thank you!

[frankrousseau]

About printit, it works that way:

• it disables color in production mode.
• it displays debug in dev mode.

From my point of view log levels are useless for a simple software like Cozy Light. Why do you need it?

[maboiteaspam]

really !! disables color ? !! Why ? I don t get it sorry. Anyway, can we make it configurable at runtime ?

[frankrousseau]

Open an issue on the dedictaed repository describing your requirements. Then, we'll see what we could do.

[frankrousseau]

Ok. I'm working on the merge, please do not commit anymore on this PR. I expect to finish next week.

[maboiteaspam]

Seems ok for shipping now. I fixed some late stuff. I ll delay some other updates to later.

The problems i lately found was sufficiently important that i don t respect your demand to not commit on it. Hope it won t be too much troubles.

[frankrousseau]

Ok np, thank you!

[frankrousseau]

Sorry I can't integrate your recent commit I renamed file and it make thinks too complex to merge them. I'll tell you when I will finish the merge.

[frankrousseau]

I merged this PR so you can open a new one if you want to make fixes. I changed requires to make them look more like the Node way.
Tests failed, I will fix it soon.

[frankrousseau]

Thank you for that big work on the codebase. That's very helpful.

[maboiteaspam]

Hi,

Don t worry it s not finish ; ) But at least we can focus on other topics now this is more workable.

I ll give a check to the test and the merge later!

thank you.

[maboiteaspam]

Hi,

i did not see the heavy changes you are still doing until now.

Do you mind using an alternate branch than master for such large changes ?

[maboiteaspam]

This said, you maybe interested to merge this commit too,
maboiteaspam@5b43bdc

helps to detect faulty apps / plugin / main server in their stop sequence.