fix: Restart sync loop when resuming from sleep #2370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the computer goes to sleep, we stop the synchronization lifecycle which results in suspending the synchronization loop. The `resume()` method used to call the `start()` method which in turn starts the synchronization loop. However, the `resume()` method now has its own actions and we forgot to start the synchronization loop as part of them. This resulted in changes not being synchronized although they were detected by the watchers.
This clarifies what the sync loop does (especially the part about waiting for new changes to synchronize) and avoids duplicating code in the `start()` and `resume()` methods.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the computer goes to sleep, we stop the synchronization lifecycle
which results in suspending the synchronization loop.
The
resume()method used to call thestart()method which in turnstarts the synchronization loop.
However, the
resume()method now has its own actions and we forgotto start the synchronization loop as part of them.
This resulted in changes not being synchronized although they were
detected by the watchers.
Please make sure the following boxes are checked: