-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Structured Append #132
Open
kousu
wants to merge
8
commits into
cozmo:master
Choose a base branch
from
kousu:structured-append
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Structured Append #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here's some open questions:
|
…rite "M/N" page numberings. Some of the output.jsons were hand-massaged to be what they should be, rather than what generate-test-data currently would give, because this feature doesn't work yet. amen.mp3 is public domain from https://sampleswap.org//samples-ghost/DRUM%20LOOPS%20and%20BREAKS/161%20to%20180%20bpm/128[kb]161_amenvar3.aif.mp3
It's important that this is done sync, not async, because there's a stateful part that places parts into an array by their page number, and if the separate subparts run async from each other the ordering gets messed up.
- I remembered that the parity byte exists, so I test that too - bumped the output data down into a sub-member (result.structuredAppend.{M,N,parity}) and gave it a TypeScript type - bumped M and N up to be 1-based, following the QR spec
The assert line is weird. In structured-append-test.ts I can use ``` import { strict as assert } from 'assert'; ``` But here I can't and I have to use ``` import * as assert from 'assert'; ``` (ref: https://stackoverflow.com/questions/39883960/what-is-the-typescript-2-0-es2015-way-to-import-assert-from-node-js) Oh well??
As you can see from the diff, this only adds missing byte chunks and the new structured append chunks, plus 15 newly passing tests :) Previously, in 7d113b2, I had generated the expected output using https://github.com/glassechidna/zxing-cpp/. Now, the expected output was made by jsQR. The fact that the diff shows no change in that part of the output.jsons means this feature branch is correct :)
Another issue: if I try to use
But this doesn't happen if I just |
This was referenced Apr 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #128 .