Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new chains to DAO Snapshot Voting Strategies #12

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

yvesfracari
Copy link

Description

This PR includes the Base and Arb COW tokens on the snapshot voting strategies and refactors all the strategies' names to erc20-balance-of-with-delegation to the strategy fits in the max length (8).

Changes

  • Add the Arb and Base bridged COW tokens into the settings.
  • Refactor all strategies to use erc20-balance-of-with-delegation to reduce total strategy length.

How to test

  1. Check that the erc20-balance-with-delegation returns the sum of the token balance and the delegations by using the playground.
  2. Do the same for arbitrum and base strategies.
  3. Check this testing space created with the new strategies. Note: on this space strategy we added a additional delegationSpace to sync with the main space delegations. This param by default is equal to the strategy space and that is why is not added on the PR.

Copy link

github-actions bot commented Jan 13, 2025

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@yvesfracari
Copy link
Author

I have read the CLA Document and I hereby sign the CLA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant