default SOLR_SSL_PORT to SOLR_PORT #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinrsweeney
pushed a commit
that referenced
this pull request
May 5, 2023
patsonluk
pushed a commit
that referenced
this pull request
Sep 21, 2023
Co-authored-by: Jan Høydahl <[email protected]>
justinrsweeney
pushed a commit
that referenced
this pull request
Oct 18, 2023
Co-authored-by: Jan Høydahl <[email protected]> (cherry picked from commit 51c1a78)
justinrsweeney
pushed a commit
that referenced
this pull request
Nov 2, 2023
Co-authored-by: Jan Høydahl <[email protected]> (cherry picked from commit 51c1a78)
justinrsweeney
pushed a commit
that referenced
this pull request
Apr 26, 2024
Co-authored-by: Jan Høydahl <[email protected]> (cherry picked from commit 51c1a78)
nginthfs
pushed a commit
that referenced
this pull request
May 22, 2024
Co-authored-by: Jan Høydahl <[email protected]> (cherry picked from commit 51c1a78)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quick update PR to #94, this allows running Solr HTTPS on ports other than
8983. Before, if you set-p 28983,SOLR_SSL_PORTwould still default to8983. If you're intending to start an HTTPS server, this is confusing, since-ponly setsSOLR_PORTand notSOLR_SSL_PORT. Setting it here instead of in the-pswitch case allows the user to setSOLR_SSL_PORTvia env.