Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SAI-5261: fix CaffeineCache.put ramBytes decrement #240

Merged
merged 3 commits into from
Dec 9, 2024
Merged

SAI-5261: fix CaffeineCache.put ramBytes decrement #240

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41aa2c5
SAI-5261: fix CaffeineCache.put ramBytes decrement
magibney Dec 9, 2024
c2abbc6
work around shortcircuited `onRemoval` notification for identical rep…
magibney Dec 9, 2024
7da88bd
because of edgecase re: string deduplication and identical value, ran…
magibney Dec 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion solr/core/src/java/org/apache/solr/search/CaffeineCache.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,8 @@ public V computeIfAbsent(K key, IOFunction<? super K, ? extends V> mappingFuncti
public V put(K key, V val) {
inserts.increment();
V old = cache.asMap().put(key, val);
recordRamBytes(key, old, val);
// ramBytes decrement for `old` happens via #onRemoval
recordRamBytes(key, null, val);
return old;
}

Expand Down
Loading