Simplified aggregated metric fetching logic #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r to speed things up
patsonluk
merged commit be9d296
into
noble/patson/aggregate_prometheus_metrics
6 of 7 checks passed
patsonluk
deleted the
noble/patson/aggregate_prometheus_metrics_combined
branch
patsonluk
restored the
noble/patson/aggregate_prometheus_metrics_combined
branch
patsonluk
added a commit
that referenced
this pull request
Oct 2, 2024
* Use aggregate metrics where possible * typo * Added support for all attributes * Added support cumulative adds and errors * Added test for cumulative adds and errors * refactored to eliminate hard coing keys * added all other available metrics * refactor * 1. Added more explicit dependency between AggregateMetricsApiCaller and CoresMetricsApiCaller 2. CoresMetricsApiCaller will only fetch metrics that are missing from AggregateMetricsApiCaller 3. Added capability to get property other than counter (for median duration etc) - Added support of key and expr on top of prefix/property for metrics api querying 4. Some fixes to label and unit test cases 5. Added metricType to CoreMetric to retain correct Prometheus metrics type * Fixed gradle check error * Added p50 p95 and p99 metrics for various ops * Fixed test case issue * ./gradlew tidy * Fixed local update metrics * Temporarily disabled the CoresMetricsApiCaller * Do not call metricx expr, as it's costly * Do not call metricx expr, as it's costly * Simplified aggregated metric fetching logic (#221) * Combine both core and solr.node metrics into AggregateMetricsApiCaller to speed things up * Fixed metrics api property query param * Fixed metrics api property query param * Avoid NPE * javadoc code cleanup re-arranged CoreMetric enum ordering to fit the test case * Undo unnecessary change * Fixed a logic error * ./gradlew tidy * Use 2 prometheus metrics calls (#222) * Try making 2 calls and see if it's faster * Try making 2 calls and see if it's faster * Fixed unit test cases * ./gradlew tidy * Use meter for autocommit metrics * Adjust PrometheusMetricsServlet after changing to meter for autocommit metrics * ./gradlew tidy and fixing unit test cases --------- Co-authored-by: noblepaul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merging to my another work branch, the real review will happen on that work branch