we must also guard mmap'd access in AccessDirectory #185
Conversation
Wiz Scan Summary
|
| @@ -92,6 +92,15 @@ static OpenOption getDirectOpenOption() { | |||
| private final boolean useAsyncIO; | |||
| private final boolean useDirectIO; | |||
|
|
|||
| public CompressingDirectory( | |||
There was a problem hiding this comment.
Excuse me if I missed it but I'm not seeing this new constructor used anywhere, is this necessary now or for something in the future?
There was a problem hiding this comment.
Added a public ctor here in order to make NodeLevelTeeDirectoryState class public (for external use, e.g. in tests and transfer scripts), without having to make the internal fields accessible.
This is a good callout though, let me see if I can adjust this to make it a little more clear how this is supposed to be used.
There was a problem hiding this comment.
Updated usages to make it clear that the preferred/public ctor is the one that takes NodeLevelTeeDirectoryState arg. This will hopefully make it a little less unusual-looking!
…y/better-guard-mmap-accessdirectory
| @@ -578,14 +580,20 @@ private static ByteBufferGuard.BufferCleaner unmapHack() { | |||
| } | |||
| } | |||
|
|
|||
| static final class LazyLoadInput extends IndexInput implements RandomAccessInput { | |||
| public interface LazyLoad { | |||
There was a problem hiding this comment.
Is this interface necessary right now? It looks like we don't reference anything by this interface, and only have one implementation of it. Is this something that's more forward looking, for when we are upstreaming this in the future?
There was a problem hiding this comment.
Thanks! yeah; this is similar to the above -- this interface is used in testing by external code. I added a comment to this effect in 6fb2dab
* we must also guard mmap'd access in AccessDirectory * tidy * slightly different way to alter TeeDirectory test path scoping * preferred public ctor for CompressingDirectory takes NodeLevelTeeDirectoryState * add comment about CompressingDirectory ctor * add a comment about seemingly superfluous interface `LazyLoad`
opening this PR against
fs/branch_9_3; will forward-port tofs/branch_9x.