Disable start request logs for get request #171
Conversation
| .asShallowMap(false) | ||
| .put( | ||
| "params", "{" + filteredParams + "}"); // replace "params" with the filtered version | ||
| } else { |
There was a problem hiding this comment.
I'm wondering if instead of wrapping this in a check that the request is a "select" request, we should instead:
- Change this else to be
else if (isDistrib(req))to only log on distrib requests - Change the log level for these to debug so they don't log by default but we could enable if needed
There was a problem hiding this comment.
Today, we log Start External Search Query on query aggregator node, when alexa-request hits to QA node. Then we log Start Forwarded Search Query on data node for each sub-shard request. Thus both if-else are relevant in context of select request.
if we want debug-logging for get request then need to find some other place as RealTimeGetHandler extends the SearchHandler.
Let me know if this looks reasonable
There was a problem hiding this comment.
My thinking is that we'd generally want this logged for any distributed query, where gets are non-distributed queries. That's why I think instead of just looking for the path contains "select" we could just change the else to isDistrib(req) and then this wouldn't log for any non-distributed requests, including gets.
The debug is totally optional, was thinking debug if we find we don't need these much in general.
|
Should we merge this into fs/branch_9x instead of branch_9_3? |
Disabling the start log for
/getrequest. Initially we added this log debuggingselectrequest. Thus just keeping that log for select request only.This reduces almost 33% of log lines as we make many get requests.