SOLR-17076: Optimize placement factory get all replica #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/SOLR-17076
Description
OrderedNodePlacementPlugin#getAllReplicasOnNode
can be slow in a cluster with lot of replicas. The effect could compound with new collection creation with many shards.Solution
Introduced a new field
allReplicas
which keeps track of all the replicas added/removed in the Plugin. Return a copy of that set instead forgetAllReplicasOnNode
.Also added a new convenient method
getAllReplicaCount
if only the count is neededTests
A minor change, rely on existing unit test case
Checklist
Please review the following and check all that apply:
main
branch../gradlew check
.