Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing glob pattern parsing to handling non docvaluesasstored fields #157

Open
wants to merge 1 commit into
base: fs/branch_9_3
Choose a base branch
from

Conversation

justinrsweeney
Copy link

No description provided.

…for all field types except SortableTextField
@justinrsweeney justinrsweeney changed the title Fixing glob pattern parsing to handling non docvaluesasstored fields … Fixing glob pattern parsing to handling non docvaluesasstored fields Oct 6, 2023
@magibney
Copy link
Collaborator

So now all fields that are not SortableTextField will be returned for value retrieval glob patterns, regardless of the setting of useDocValuesAsStored? Is that really what we want?

I may be missing some context -- which expected values were not getting returned?

@justinrsweeney
Copy link
Author

So now all fields that are not SortableTextField will be returned for value retrieval glob patterns, regardless of the setting of useDocValuesAsStored? Is that really what we want?

I may be missing some context -- which expected values were not getting returned?

I think that is what we want here where behavior actually should deviate from glob patterns for select. Currently for us for example, we don't get fields like UserEmailStr since it is docvalues, but has useDocValuesAsStored="false". Given non-docvalues fields can't be used with the export handler, it doesn't seem like caring about the useDocValuesAsStored option makes sense here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants