Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-16654: Add support for node-level caches (apache/solr#1351) #138

Open
wants to merge 2 commits into
base: fs/branch_9_3
Choose a base branch
from

Conversation

magibney
Copy link
Collaborator

@magibney magibney commented Sep 5, 2023

Backporting directly to fs/branch_9_3. Since fs/branch_9x has already separated from fs/branch_9_3, the upstream change will be pulled into fs/branch_9x before 9.4, so we don't need to backport this there.

<query>
<filterCache
class="solr.ThinCache"
parentCacheName="myNodeLevelCacheThin"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

myNodeLevelCacheThin needs to define in solr.xml?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, exactly.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the motivation to keep this separate (not in solrconfig)? Would be good to have cacheref element in colrconfig ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the motivation to keep this separate (not in solrconfig)?

The cache is configured in the config file that's associated with the same scope as the cache itself. solrconfig.xml configures properties associated with the collection/core. A node-level cache is configured in the node-level config file, solr.xml.

What is the motivation to keep this separate (not in solrconfig)? Would be good to have cacheref element in colrconfig ?

I'm not sure I understand?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like both should be configure in one place ? probably its easier to track

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants