introduce first-class cache for OrdinalMaps #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
backport unmerged upstream PR at commit 9eeb7e0
magibney
force-pushed
the
michaelgibney/ordinal-map-cache
branch
from
9f97944 to
d9be388
Compare
|
force-pushed an update backported directly from as-yet-unmerged upstream PR. Changed the base branch to |
justinrsweeney
approved these changes
Sep 12, 2023
magibney
added a commit
that referenced
this pull request
Sep 12, 2023
This was referenced Nov 24, 2023
justinrsweeney
pushed a commit
that referenced
this pull request
Apr 26, 2024
backport unmerged upstream PR at commit 9eeb7e0 * include updates to accommodate FS custom CacheConfig ctor signature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
building on recent upstream work that stores OrdinalMaps in a ConcurrentHashMap, here we make OrdinalMap caching configurable within the standard Solr caching framework. This allows, e.g., OrdinalMap caches to be directly warmed, etc...
A couple of things to note:
fs/branch_9xupon which this is based seems currently to be failing, so we should merge fromfs/branch_9xafter merging remaining fixes (compile and forbiddenAPIs) after merge from upstream branch_9x #118 to get meaningful CI results for this PR. EDIT: DONE