SAI-5303: Fix metrics api caller request property formatting/missing …

…metrics (#243)
cowpaths · Dec 17, 2024 · e716b58 · e716b58
1 parent b7ac84d
commit e716b58
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/solr/core/src/java/org/apache/solr/servlet/PrometheusMetricsServlet.java b/solr/core/src/java/org/apache/solr/servlet/PrometheusMetricsServlet.java
@@ -1111,11 +1111,10 @@ private abstract static class MetricsByPrefixApiCaller extends MetricsApiCaller
     @Override
     protected String buildQueryString(ResultContext resultContext) {
       String propertyClause =
-          String.join(
-              "&property=",
-              Arrays.stream(properties)
-                  .map(p -> URLEncoder.encode(p, StandardCharsets.UTF_8))
-                  .collect(Collectors.toSet()));
+          Arrays.stream(properties)
+              .map(p -> URLEncoder.encode(p, StandardCharsets.UTF_8))
+              .distinct()
+              .collect(Collectors.joining(",", "&property=", ""));
       return String.format(
           Locale.ROOT,
           "wt=json&indent=false&compact=true&group=%s&prefix=%s%s",