Ignoring _version_ field for glob patterns on export since we typical…

…ly do not want that returned unless specifically added as an fl param (#98)

* Ignoring _version_ field for glob patterns on export since we typically do not want that returned unless specifically added as an fl param

* Using CommonParams property and adding test

* Tidying code

* Fixing message for test

solr/core/src/java/org/apache/solr/handler/export/ExportWriter.java

@@ -875,6 +875,10 @@ private void getGlobFields(
       Set<String> fieldsProcessed,
       List<SchemaField> expandedFields) {
     for (FieldInfo fi : searcher.getFieldInfos()) {
+      if (CommonParams.VERSION_FIELD.equals(fi.getName())) {
+        // Ignore _version_ unless specified
+        continue;
+      }
       if (FilenameUtils.wildcardMatch(fi.getName(), fieldPattern)) {
         SchemaField schemaField = searcher.getSchema().getField(fi.getName());
         if (fieldsProcessed.add(fi.getName())

solr/core/src/test/org/apache/solr/handler/export/TestExportWriter.java

@@ -1333,6 +1333,8 @@ public void testGlobFields() throws Exception {
     assertFalse(
         "Fields without docvalues and useDocValuesAsStored should not be returned",
         jq.contains("\"sortabledv\""));
+    assertFalse(
+        "_version_ should not be returned as part all fields", jq.contains("\"_version_\""));
   }
 
   @SuppressWarnings("rawtypes")