Ratelimiting should only log when a request is actually rate-limited (#…

…200)
cowpaths · May 16, 2024 · 9892b9b · 9892b9b
1 parent 1c904a0
commit 9892b9b
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/solr/core/src/java/org/apache/solr/servlet/ServletUtils.java b/solr/core/src/java/org/apache/solr/servlet/ServletUtils.java
@@ -204,10 +204,10 @@ static void rateLimitRequest(
       Runnable limitedExecution)
       throws ServletException, IOException {
     try (RequestRateLimiter.SlotReservation accepted = rateLimitManager.handleRequest(request)) {
-      if (log.isInfoEnabled()) {
-        log.info("rate limit request {}", request.getRequestURI());
-      }
       if (accepted == null) {
+        if (log.isInfoEnabled()) {
+          log.info("rate limit request {}", request.getRequestURI());
+        }
         response.sendError(ErrorCode.TOO_MANY_REQUESTS.code, RateLimitManager.ERROR_MESSAGE);
         return;
       }