Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide non mobile optimized menu items #468

Merged
merged 4 commits into from
Aug 11, 2020

Conversation

ibeckermayer
Copy link
Contributor

closes #467

kyle-mcr and others added 2 commits August 8, 2020 11:22
…the issue with safari and adjusted the width and height to achieve tha same size
Copy link
Contributor

@leon-i leon-i left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great - and seems easy to roll back once we get the other pages mobile-friendly.

Do we care about the tablet view at all? It seems like most pages work for tablet except the settings page, pictured here:

image

Not sure how many people will be using tablets, but it's worth considering - especially as the includemedia library can target specifically the tablet view.

@ibeckermayer
Copy link
Contributor Author

Looks great - and seems easy to roll back once we get the other pages mobile-friendly.

Do we care about the tablet view at all? It seems like most pages work for tablet except the settings page, pictured here:

image

Not sure how many people will be using tablets, but it's worth considering - especially as the includemedia library can target specifically the tablet view.

Probably eventually we'll want that, but for now let's just focus on getting desktop to play nicely with mobile

@ibeckermayer ibeckermayer merged commit 631f272 into dev Aug 11, 2020
@ibeckermayer ibeckermayer deleted the hide-non-mobile-optimized-menu-items branch August 11, 2020 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide menu items for pages that aren't optimized for mobile
3 participants