Closing Add Member Modal Now Resets State #418
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colbymorrison
requested changes
Jul 29, 2020
|
Weird - I wasn't getting that locally. I'll look into it. |
|
This is how it looks for me locally:
Perhaps the issue is browser based? I'm using chrome. |
ibeckermayer
approved these changes
Jul 29, 2020
There was a problem hiding this comment.
Looks good to merge, though let's figure out what @colbymorrison's issue is and at least make an issue for it.
|
Hm yeah, since it looks that way for you I’d guess it is a browser thing or something related to that, I’m using Firefox. |
colbymorrison
approved these changes
Jul 29, 2020
|
Added an issue here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #417
Adding a member now clears the state so their information does not appear again when opening modal. Closing a modal while in progress of adding a member now resets state as well.