Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dt 7256 ignored razor expressions environment variable only works from command line #264

Conversation

jocgir
Copy link
Contributor

@jocgir jocgir commented Oct 8, 2024

This pull request includes various changes to improve documentation, correct typos, and enhance functionality in several files. The most important changes include adding a new ignore words list to the .cspell.json file, fixing typos across multiple files, and enhancing the applyRazor function for better regex handling.

Documentation and Comments:

  • .cspell.json: Added a comprehensive list of words to ignore for spell checking.
  • template/doc.go: Added a detailed package-level comment to describe the functionalities provided by the template package.

Typo Fixes:

Functionality Enhancements:

  • template/razor.go: Improved the applyRazor function to ensure regex is not greedy and stops at the end of the expression.
  • template/razor_test.go: Added new test cases for applyRazor function to handle strict error checking and various scenarios.

Miscellaneous:

  • README.md: Added a link to the library usage documentation.
  • main.go: Updated the documentation URL.
  • render-doc: Modified the script to exclude specific lines from the README.

@jocgir jocgir requested a review from a team as a code owner October 8, 2024 20:47
.cspell.json Show resolved Hide resolved
template/razor.go Outdated Show resolved Hide resolved
template/template.go Outdated Show resolved Hide resolved
@jonapich
Copy link
Contributor

jonapich commented Oct 8, 2024

Mon IDE me montre des warnings un peu partout:
image

@jocgir jocgir force-pushed the DT-7256-Ignored-razor-expressions-environment-variable-only-works-from-command-line branch from 6efd859 to c4bb57c Compare October 9, 2024 12:27
@jocgir
Copy link
Contributor Author

jocgir commented Oct 9, 2024

C'est discutable, mais je l'ai changé.

By default, the variable must be Capitalized
@jocgir jocgir force-pushed the DT-7256-Ignored-razor-expressions-environment-variable-only-works-from-command-line branch from f8d631f to 741ba03 Compare October 9, 2024 13:49
@jocgir jocgir merged commit e91e172 into master Oct 9, 2024
3 checks passed
@jocgir jocgir deleted the DT-7256-Ignored-razor-expressions-environment-variable-only-works-from-command-line branch October 9, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants