Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for JDK 21 on various distributions #215

Merged
merged 6 commits into from
Sep 25, 2023

Conversation

ckipp01
Copy link
Collaborator

@ckipp01 ckipp01 commented Sep 22, 2023

This also updates the deps, scala-cli script, and scalafmt

@ckipp01
Copy link
Collaborator Author

ckipp01 commented Sep 22, 2023

@alexarchambault if you want I'm also happy to help maintain this repo since I use cs to manage my java versions locally. That way we can have multiple eyes on things and it doesn't have to all be on your shoulders.

@carlosedp
Copy link
Contributor

Not totally related to this PR but should we also add to the index Oracle JDKs from https://www.oracle.com/java/technologies/downloads/ ?

@alexarchambault
Copy link
Member

@ckipp01 Just sent you an invite to have write access to this repo. PRs updating the index need to be approved (by a maintainer) before being merged (squash-and-merge). I usually do a visual quick check that all new URLs look legit.

@alexarchambault
Copy link
Member

@carlosedp It'd be great to have those. I'm not sure how stable those URLs are though (it'd be better if they don't disappear in the future), and how to automate adding them to the index.

@alexarchambault
Copy link
Member

Thanks for this @ckipp01!

@alexarchambault alexarchambault merged commit 7b90842 into coursier:master Sep 25, 2023
2 checks passed
@alexarchambault alexarchambault mentioned this pull request Sep 25, 2023
@carlosedp
Copy link
Contributor

Sorry to pollute this now closed PR, I might open one adding GraalVM ones.
According to GraalVM's blog post, the have "stable scriptable URLs". So I believe the plan is to keep they working :)

Ref: https://medium.com/graalvm/a-new-graalvm-release-and-new-free-license-4aab483692f5

@alexarchambault
Copy link
Member

Per https://www.oracle.com/java/technologies/jdk-script-friendly-urls/, linked in the blog post you mentioned, not only GraalVM, but also standard JDKs are available this way. This page also mentions the lifetime of those URLs (which should be fine for us).

@ckipp01 ckipp01 deleted the 21 branch September 25, 2023 16:39
@carlosedp
Copy link
Contributor

I tried cs java --available --update --ttl 0 | grep graal but java21 still doesn't show in the index.
Anything missing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants