Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Search element <select> only #82

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chung1905
Copy link

@chung1905 chung1905 commented Nov 13, 2019

Hello,

First thing I want to say is this repository is very helpful, an open source country/region data. Thank you so much.
Then, here's my small pull request:

  • Because in the code, we write somethings like: countryElement.options[countryElement.length] = new Option(countries[i][0], val); without checking if options has been defined or not.
  • I know countryElement always has options attribute if it's element. But if it is not, some unfriendly logs will be shown in console. => I have made a small commit to query .crs-country on elements only.

    Thank you again for the repository.

    Edit: typos

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant