Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CBG-3507: Add unsupported.allow_dbconfig_env_vars #6496

Merged
merged 3 commits into from
Oct 5, 2023
Merged

Conversation

bbrks
Copy link
Member

@bbrks bbrks commented Oct 5, 2023

CBG-3507

Opt-out for database config env var expansion

Integration Tests

adamcfraser
adamcfraser previously approved these changes Oct 5, 2023
Copy link
Collaborator

@adamcfraser adamcfraser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one nitpick/suggestion you can take or leave.

rest/handler.go Outdated Show resolved Hide resolved
@adamcfraser adamcfraser changed the title CBG-3507: Add unsupported.disallow_dbconfig_env_vars CBG-3507: Add unsupported.allow_dbconfig_env_vars Oct 5, 2023
@adamcfraser adamcfraser merged commit ce51e97 into master Oct 5, 2023
@adamcfraser adamcfraser deleted the CBG-3507 branch October 5, 2023 17:43
torcolvin pushed a commit that referenced this pull request Oct 31, 2023
* Add unsupported.disallow_dbconfig_env_vars to opt out of db config env var expansion

* Add test for DisallowDbConfigEnvVars coverage

* Flip bool (default to true)
bbrks added a commit that referenced this pull request Mar 28, 2024
* Add unsupported.disallow_dbconfig_env_vars to opt out of db config env var expansion

* Add test for DisallowDbConfigEnvVars coverage

* Flip bool (default to true)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants