Fall through to default case for strings, but leave warning comment…

… to make it clear it was an intentional decision to fall through for strings.
couchbase · Nov 29, 2023 · eceb0b5 · eceb0b5
1 parent 3fc4c51
commit eceb0b5
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/base/util.go b/base/util.go
@@ -1309,9 +1309,9 @@ func InjectJSONProperties(b []byte, kvPairs ...KVPair) (new []byte, err error) {
 			valBytes = []byte(strconv.FormatUint(v, 10))
 		case bool:
 			valBytes = []byte(strconv.FormatBool(v))
-		case string:
-			// it's not safe to use strings without marshalling
-			valBytes = []byte(ConvertToJSONString(v))
+		// case string:
+		// it's not safe to use strings without marshalling
+		// fall through to default below
 		default:
 			valBytes, err = JSONMarshal(kv.Val)
 		}