Change counterpartyInfo to channel #100
Open
+166
−137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdityaSripal
commented
Nov 14, 2024
| @@ -52,7 +52,7 @@ test-e2e testname: | |||
|
|
|||
| # Install the sp1-ics07-tendermint operator for use in the e2e tests | |||
| install-operator: | |||
| cargo install --git https://github.com/cosmos/sp1-ics07-tendermint --rev {{sp1_operator_rev}} sp1-ics07-tendermint-operator --bin operator --locked | |||
| cargo +nightly install --git https://github.com/cosmos/sp1-ics07-tendermint --rev {{sp1_operator_rev}} sp1-ics07-tendermint-operator --bin operator --locked | |||
There was a problem hiding this comment.
i had to do this to get it to install on my machine. Can remove if desired
There was a problem hiding this comment.
Ah yes, makes sense. The most recent operator commit doesn't need this since we removed the union dependencies
AdityaSripal
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR renames
counterpartyInfotochannelMoreover it does not assume that the counterpartyId is necessarily a clientID. I think here the logic looks much more in-line with IBC-go and hopefully will do a lot to remove the confusions raised in the referenced spec issue.
For now, I have a single contract implementing ICS02 and ICS04 specs since ICS04 doesn't have too many additional functions. I can rename the file to
CoreRouterto make this clearer rather than ICS02Client.TODO:
ref: cosmos/ibc#1164
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.