fix: enable pagination and introduce new response data in queries #2398
+236
−169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes: #2385, #2386
Testing
To verify pagination works as expected for
list-consumer-chains
, we locally modified contrib/local-testnet.sh so that it starts 150 consumer chains and then we opt in to some of those chains in order to launch them. Specifically, we launch 112 of those chains and then executed commands similar to the ones below to verify everything works as expected:When counting all the chains:
./build/interchain-security-pd query provider list-consumer-chains --node http://127.0.0.1:29170 --count-total
we get:
When counting all the
Launched
chains:./build/interchain-security-pd query provider list-consumer-chains 3 --node http://127.0.0.1:29170 --count-total
we get:
When counting all the
Registered
chains:./build/interchain-security-pd query provider list-consumer-chains 1 --node http://127.0.0.1:29170 --count-total
we get:
Additionally, queries like this
./build/interchain-security-pd query provider list-consumer-chains 1 --node http://127.0.0.1:29170 --limit 2 --page-key "AAAAAAAAAAI3OQ==" --reverse
work as expected by returning
Registered
chains in the reverse order.Note that when
page-key
is used thetotal
count is not computed (seeFilteredPaginate
).Also the following query works as expected:
./build/interchain-security-pd query provider list-consumer-chains 3 --node http://127.0.0.1:29170 --limit 2 --page 4
by returning the 5th page (0-index on pages) of initialized chains with 2 chains in each page.
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if the change is state-machine breakingCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...
!
the type prefix if the change is state-machine breaking