Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: a Rust linter warning #359

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

larry0x
Copy link
Contributor

@larry0x larry0x commented Aug 29, 2024

The use ics23; statement in the no-std check crate triggers the following linter warning:

warning: this import is redundant
 --> no-std-check/src/lib.rs:9:1
  |
9 | use ics23;
  | ^^^^^^^^^^ help: remove it entirely
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports
  = note: `#[warn(clippy::single_component_path_imports)]` on by default

This can be fixed by changing it to use ics23::*;.

Copy link

codecov bot commented Aug 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.55%. Comparing base (1363533) to head (ca29ba9).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #359   +/-   ##
=======================================
  Coverage   65.55%   65.55%           
=======================================
  Files           7        7           
  Lines        3609     3609           
=======================================
  Hits         2366     2366           
  Misses       1243     1243           
Flag Coverage Δ
rust 65.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@colin-axner colin-axner requested a review from romac October 8, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant