Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.48.0: addendum #982

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Release v0.48.0: addendum #982

merged 3 commits into from
Nov 23, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Nov 23, 2023

Remark

Moved tests that use fixtures from ibc-testkit to the corresponding modules under the ibc-testkit. Therefore, completely decoupled ibc from ibc-testkit crate.

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review November 23, 2023 18:17
Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 77 lines in your changes are missing coverage. Please review.

Comparison is base (6f04205) 70.23% compared to head (4ed5b59) 70.30%.

Files Patch % Lines
...kit/src/fixtures/core/connection/conn_open_init.rs 90.72% 14 Missing ⚠️
...stkit/src/fixtures/core/channel/acknowledgement.rs 94.66% 4 Missing ⚠️
...it/src/fixtures/core/channel/chan_close_confirm.rs 96.52% 4 Missing ⚠️
...stkit/src/fixtures/core/channel/chan_close_init.rs 95.74% 4 Missing ⚠️
...testkit/src/fixtures/core/channel/chan_open_ack.rs 97.63% 4 Missing ⚠️
...kit/src/fixtures/core/channel/chan_open_confirm.rs 96.63% 4 Missing ⚠️
...estkit/src/fixtures/core/channel/chan_open_init.rs 95.18% 4 Missing ⚠️
...testkit/src/fixtures/core/channel/chan_open_try.rs 96.72% 4 Missing ⚠️
ibc-testkit/src/fixtures/core/channel/mod.rs 97.20% 4 Missing ⚠️
ibc-testkit/src/fixtures/core/channel/packet.rs 98.25% 4 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #982      +/-   ##
==========================================
+ Coverage   70.23%   70.30%   +0.07%     
==========================================
  Files         177      178       +1     
  Lines       17733    17692      -41     
==========================================
- Hits        12455    12439      -16     
+ Misses       5278     5253      -25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@rnbguy rnbguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@Farhad-Shabani Farhad-Shabani changed the title fix: remove version for ibc-testkit in workspace Release v0.48.0: addendum Nov 23, 2023
@Farhad-Shabani Farhad-Shabani merged commit 8c1766f into main Nov 23, 2023
15 checks passed
@Farhad-Shabani Farhad-Shabani deleted the farhad/fix-testkit-dev-dep branch November 23, 2023 22:31
@Farhad-Shabani Farhad-Shabani added this to the v0.48.0 milestone Nov 24, 2023
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
* fix: remove version for ibc-testkit

* chore: move ibc tests using ibc-testkit

* chore: rename utils to fixtures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants