Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

f32/f64/usize in cosmwasm(and other no f32/f64 envs) reproduction and fixes #894

Merged
merged 18 commits into from
Oct 13, 2023

Conversation

Farhad-Shabani
Copy link
Member

@Farhad-Shabani Farhad-Shabani commented Oct 2, 2023

Closes: #850
Supersedes: #803

Remark

  • As CI took ~13 mins to run cw-check, set CI to run on releases and the main branch.

PR author checklist:

  • Added changelog entry, using unclog.
  • Added tests.
  • Linked to GitHub issue.
  • Updated code comments and documentation (e.g., docs/).
  • Tagged one reviewer who will be the one responsible for shepherding this PR.

Reviewer checklist:

  • Reviewed Files changed in the GitHub PR explorer.
  • Manually tested (in case integration/unit/mock tests are absent).

@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (a2efb0e) 67.67% compared to head (8087faa) 67.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #894      +/-   ##
==========================================
- Coverage   67.67%   67.51%   -0.16%     
==========================================
  Files         131      131              
  Lines       16079    16091      +12     
==========================================
- Hits        10881    10864      -17     
- Misses       5198     5227      +29     
Files Coverage Δ
crates/ibc/src/applications/transfer/amount.rs 85.41% <100.00%> (+0.15%) ⬆️
crates/ibc/src/applications/transfer/denom.rs 74.52% <100.00%> (+0.19%) ⬆️
crates/ibc/src/applications/transfer/error.rs 28.00% <ø> (ø)
...s/ibc/src/clients/ics07_tendermint/client_state.rs 72.83% <100.00%> (ø)
...src/core/ics03_connection/handler/conn_open_try.rs 91.26% <100.00%> (-2.43%) ⬇️
crates/ibc/src/core/ics04_channel/context.rs 100.00% <100.00%> (+1.81%) ⬆️
crates/ibc/src/core/ics04_channel/error.rs 26.08% <ø> (ø)
...tes/ibc/src/core/ics24_host/identifier/validate.rs 100.00% <100.00%> (ø)
crates/ibc/src/mock/context.rs 75.21% <100.00%> (ø)
crates/ibc/src/core/ics04_channel/channel.rs 60.69% <66.66%> (ø)
... and 3 more

... and 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Farhad-Shabani Farhad-Shabani marked this pull request as ready for review October 3, 2023 01:46
@Farhad-Shabani
Copy link
Member Author

Hey @tzemanovic, Could you please take a look at this branch and let me know if it fits your needs? Thanks!

@tzemanovic
Copy link
Contributor

Hey @tzemanovic, Could you please take a look at this branch and let me know if it fits your needs? Thanks!

It does, thank you!

crates/ibc/clippy.toml Outdated Show resolved Hide resolved
crates/ibc/clippy.toml Outdated Show resolved Hide resolved
Farhad-Shabani and others added 2 commits October 13, 2023 06:57
Co-authored-by: Romain Ruetschi <[email protected]>
Signed-off-by: Farhad Shabani <[email protected]>
@Farhad-Shabani Farhad-Shabani merged commit 245d2fc into main Oct 13, 2023
13 checks passed
@Farhad-Shabani Farhad-Shabani deleted the pr/dzmitry-lahoda/803 branch October 13, 2023 14:28
Farhad-Shabani added a commit that referenced this pull request Sep 9, 2024
… fixes (#894)

* fixed f64/f32 validation in wasm

* what to do with serde json? main one is float, fork from cw is std, my fork pr not merged for no std

* apply some adjustments + update cargo.lock for cw-check

* deps: bump serde-json-wasm to v1.0.0

* chore: add unclog

* ci: add cw-check

* fix: remove cachix

* fix: not needed to install/cache Rust in CI

* imp: run CI only on releases and main branch

* nit: on pull_request

* nit: max_history_size as u64

* test: calculate_block_delay

* nit: remove u64::max

* Apply suggestions from code review

Co-authored-by: Romain Ruetschi <[email protected]>
Signed-off-by: Farhad Shabani <[email protected]>
---------

Signed-off-by: Farhad Shabani <[email protected]>
Co-authored-by: dzmitry-lahoda <[email protected]>
Co-authored-by: Romain Ruetschi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

serde_json uses floats that may be disallowed in WASM
4 participants